refactor: use Accounts collection instead of Meteor.users to get admin accounts #5432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
approved these changes
Aug 7, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
Funny, I fixed this the same way in my PR today
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: bugfix
Issue
Account management tables were only displaying the current user, and not showing all users that were admins (when permissions allowed). This seemed to stem from removing the publication of the
Meteor.userscollection, as we were trying to get users from that collection.Solution
Refactor to get users from the
Accounts collectioninstead.Breaking changes
None.
Testing
Shop manageradmin@localhost), see that you can see your own account, in addition to the shop admin account, in the accounts tables