Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Aug 13, 2019

Impact: minor
Type: chore

Update Reaction to use the latest version of Reaction ESLint Config, which introduces linting for React Hooks.

Breaking changes

None

Testing

  1. See that the npm package of @reatctioncommerce/esint-config is v2.1.0.
  2. See that eslint-plugin-react-hooks is installed along side as a devDependency
  3. See that the app starts with no errors
  4. See that there are no lint errors (warnings are OK)

@kieckhafer kieckhafer requested a review from willopez August 13, 2019 02:53
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kieckhafer kieckhafer merged commit 8cde2ec into develop Aug 13, 2019
@kieckhafer kieckhafer deleted the chore-kieckhafer-updateEslintRulesPackage branch August 13, 2019 20:57
@kieckhafer kieckhafer mentioned this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants