Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Aug 13, 2019

Resolves #5284, #5276, #5267, #5269
Impact: major
Type: chore|style

This PR:

  1. Fixes the remaining eslint warnings in our codebase, where applicable
  2. Disables warnings and creates tickets for eslint issues that would require a bit more refactoring / thought, such as react/no-did-update-set-state, which will be fixed when components are updated to be functional components.
  3. Removes all warning overrides in our package.json file, which now means every eslint rule we follow is now an error.
  4. Removes the eslint-changed-files CI step, which is no longer needed since every rule is an error, and our classic eslint CI check takes care of all errors.

Breaking changes

None for our codebase. Any custom code might need to be updated to obey the new lint rules.

Testing

  1. See that the app starts up
  2. See that there are 0 errors and 0 warnings when running eslint
  3. See that there are no longer any warn overrides for eslint rules in our package.json
  4. See that there is no longer the eslint-changed-files CI check run on this PR

1__reaction__bash_

@kieckhafer kieckhafer changed the title style: ignore jsdoc requirement in tests / migrations [WIP] style: ignore jsdoc requirement in tests / migrations Aug 13, 2019
@kieckhafer kieckhafer changed the title [WIP] style: ignore jsdoc requirement in tests / migrations [WIP] style: ESLint errors and warnings === 0 Aug 13, 2019
…ponent is converted to functional

Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer kieckhafer changed the title [WIP] style: ESLint errors and warnings === 0 chore|style: ESLint errors and warnings === 0 Aug 13, 2019
@kieckhafer kieckhafer requested review from machikoyasuda, mikemurray and rosshadden and removed request for rosshadden August 13, 2019 22:08
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit c8c380d into develop Aug 16, 2019
@mikemurray mikemurray deleted the style-kieckhafer-eslintFinalIssues branch August 16, 2019 20:31
This was referenced Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants