Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Part I: An admin user can filter products by uploaded CSV #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikemurray merged 35 commits into from
Aug 15, 2019
Merged

Part I: An admin user can filter products by uploaded CSV #5451

mikemurray merged 35 commits into from
Aug 15, 2019

Conversation

@machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Aug 13, 2019 •
edited
Loading

User stories

  • A user should be able to click Filter by File and see a card with an Import CSV button, and text.
  • A user should be able to click X and close the card.
  • A user should be able to upload a CSV file, and see the returned products.
  • A user should be able to see an InlineAlert reporting what number of products were found and not found.
  • A user should be able to see the total number of products found, and total number of products selected.
  • A user should be able to see an InlineAlert with an error if no products were found. The table should then show all products again.

Changes

  • Upgrades dropzone to v10, to React Hooks

Solution

  • - Add Filter by File button to Actions dropdown, with i18n'd copy.
  • - Add a Quick Edit Card
  • - Add X to the card to close the card
  • - Add a Catalyst button with the Upload option
  • - The Create Product button should disappear when the Card is there.
  • - The table should show All Products with the number of products
  • - When products are selected, show the number of selected products

Components

From Reaction: Action dropdown

This component is in Reaction, not Catalyst yet.
This dropdown is composed of Material-UI Buttons and Catalyst ConfirmDialogs.

  • Hover color is wrong.
  • "Actions" should show up after you've opened it
  • "Actions" should change color, remove border and hide the arrow once you've clicked it

Screen Shot 2019-08-12 at 9 43 08 PM

Screen Shot 2019-08-12 at 9 42 46 PM

Screen Shot 2019-08-12 at 9 42 50 PM

From Reaction x MUI: Quick Edit Card

This component is in Reaction, not Catalyst yet.
This component is composed of Material-UI Card, CardHeader, CardContent w. Reaction styling.

Screen Shot 2019-08-12 at 9 43 34 PM

Screen Shot 2019-08-13 at 10 02 33 AM

From Catalyst: Chips

Once Chips are updated in Catalyst, they'll be updated in this ticket w/ correct styles.

Testing

  1. Test a user filters products w 1 file
  2. Test a user filters products w multiple files
  3. Test a user filters products and none are found
  4. Test a user filters products and some are found, but not all
  5. Test a user filters products and selects/deselects some of them

Machiko Yasuda and others added 26 commits August 13, 2019 14:57
feat(actiondropdown): add Filter By File option
a19b6ac 
Signed-off-by: Machiko Yasuda <[email protected]>
feat(producttable): first pass at card for product table with upload …
0f651c4 
…button

Signed-off-by: Machiko Yasuda <[email protected]>
feat: Deletable filename chips, Import File button
f30b899 
Signed-off-by: Christopher Shepherd <[email protected]>
feat: parse csv values out of uploaded files, set Session array of pr…
bc8a102 
…oductIds

Signed-off-by: Christopher Shepherd <[email protected]>
chore: resolve many lint errors; update package-lock.json
29a8c83 
Signed-off-by: Christopher Shepherd <[email protected]>
chore: fix more lint issues
68f5fa2 
Signed-off-by: Christopher Shepherd <[email protected]>
feat(closebutton): close card with X
66c7ea7 
Signed-off-by: Machiko Yasuda <[email protected]>
feat(showCard): get card to show up
845a715 
Signed-off-by: Machiko Yasuda <[email protected]>
feat: upgrade dropzone to v10, use new hooks-based dropzone in Produc…
19bccb9 
…tTable

Signed-off-by: Christopher Shepherd <[email protected]>
feat: upgrade ProductMediaGallery to hooks-based dropzone invocation
8a0d573 
Signed-off-by: Christopher Shepherd <[email protected]>
feat: Upgrade mediaUploader to use newer Dropzone
e13863d 
Signed-off-by: Christopher Shepherd <[email protected]>
feat: Update mediaGallery and TagForm to use newer Dropzone
d7c11a5 
Signed-off-by: Christopher Shepherd <[email protected]>
chore: lint fixes for TagForm
2530975 
Signed-off-by: Christopher Shepherd <[email protected]>
style(actionDropdown): make the filter by csv button match better
acfc579 
Signed-off-by: Machiko Yasuda <[email protected]>
style(actionDropdown): use MenuItem instead of Button
13b83ea 
Signed-off-by: Machiko Yasuda <[email protected]>
style(actiondropdown): make it way better
19eba6e 
Signed-off-by: Machiko Yasuda <[email protected]>
fix: add All Products title w/ correct number
5ffc112 
Signed-off-by: Machiko Yasuda <[email protected]>
feat: add InlineAlert with i18n notification, also deletable Chips in…
0c0458a 
… filtered product list

Signed-off-by: Christopher Shepherd <[email protected]>
feat(selected): show selected count on product table
26c94f5 
Signed-off-by: Machiko Yasuda <[email protected]>
feat(actiondropdown): close actiondropdown when filter by card is cli…
886e281 
…cked

Signed-off-by: Machiko Yasuda <[email protected]>
chore: lint
324a630 
Signed-off-by: Machiko Yasuda <[email protected]>
fix(card): close button for card
ee81bc5 
Signed-off-by: Machiko Yasuda <[email protected]>
style(card): slide
ff42143 
Signed-off-by: Machiko Yasuda <[email protected]>
chore: lint
67fc68e 
Signed-off-by: Machiko Yasuda <[email protected]>
chore: lint
a32b15f 
Signed-off-by: Machiko Yasuda <[email protected]>
:eat: i18n
5be2902 
Signed-off-by: Machiko Yasuda <[email protected]>
@machikoyasuda machikoyasuda changed the base branch from master to develop August 13, 2019 22:14
Christopher Shepherd and others added 3 commits August 13, 2019 19:12
chore: fix most lint errors
c785a8b 
Signed-off-by: Christopher Shepherd <[email protected]>
chore: resolve remaining lint errors
8ee3e93 
Signed-off-by: Christopher Shepherd <[email protected]>
fix: fix doubletoolbar
de6cd7e 
Signed-off-by: Machiko Yasuda <[email protected]>
Christopher Shepherd added 2 commits August 13, 2019 19:58
chore: fix eslint-changed-files warning
ace2488 
Signed-off-by: Christopher Shepherd <[email protected]>
Merge branch 'machiko-christopher-combined-branch' of github.com:reac…
5f7eb75 
…tioncommerce/reaction into machiko-christopher-combined-branch
Machiko Yasuda and others added 3 commits August 13, 2019 18:01
mikemurray
mikemurray requested changes Aug 14, 2019
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no products are found, the table disappears making it impossible to clear the filters:

image

@machikoyasuda machikoyasuda changed the title Machiko christopher combined branch Part I: An admin user can filter products by uploaded CSV Aug 15, 2019
mikemurray
mikemurray approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 4c07c52 into develop Aug 15, 2019
@mikemurray mikemurray deleted the machiko-christopher-combined-branch branch August 15, 2019 00:51
@kieckhafer kieckhafer mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikemurray mikemurray mikemurray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@machikoyasuda @mikemurray