Feat bulk actions UI updates #5461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in an InlineAlert; Handle case where no products found; Chip spacing Signed-off-by: Christopher Shepherd <[email protected]>
mikemurray
requested changes
Aug 16, 2019
Member
mikemurray
left a comment
There was a problem hiding this comment.
If I filter by a file with no results sometimes I get this error
Invariant Violation: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
at invariant (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:199059:15)
at scheduleWork (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:218920:5)
at Object.enqueueSetState (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:210173:5)
at StyledComponent.Component.setState (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:86246:16)
at StyledComponent.componentWillReceiveProps (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:303309:10)
at callComponentWillReceiveProps (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:210445:14)
at updateClassInstance (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:210655:7)
at updateClassComponent (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:213698:20)
at beginWork (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:214648:16)
at performUnitOfWork (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:218316:12)
Other times I get 2 selected when filtering by a file, but there doesn't seem to be any selected products.
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Christopher Shepherd <[email protected]>
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
machikoyasuda
approved these changes
Aug 17, 2019
…roducts if files removed Signed-off-by: Christopher Shepherd <[email protected]>
Contributor
|
@willopez you can review + merge this! :D |
willopez
requested changes
Aug 21, 2019
Member
There was a problem hiding this comment.
Just one minor issue. My prouducts.csv contains three product ids, 1 is an actual product and the other two are just made up. The text in the alert is incorrect, it should say 2 products were not found.
Also,
Seeing this console error:
Warning: Material-UI: the key `leftChip` provided to the classes property is not implemented in ProductGridItems.
You can only override one of the following: isVisible,isHidden.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: bugfix
Issue
This includes the following UI fixes for Bulk Actions:
Breaking changes
n/a
Testing
Verify the above are properly implemented and styled