FIX: Remove cart items should return updated cart #5474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajporlante please sign your commit and i'll work on updating the unit-tests |
added 2 commits
August 22, 2019 22:48
Signed-off-by: James Porlante <[email protected]>
Signed-off-by: James Porlante <[email protected]>
cfbe85d to
48f65f8
Compare
Contributor
|
I refactored this function in #5477 and I believe that change will also fix this issue in a different way. |
Signed-off-by: James Porlante <[email protected]>
2552c6d to
93b88ed
Compare
Contributor
|
Should we close in favor of #5477? |
Contributor
Author
|
Closing this in favor of #5477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves N/A
Impact: critical
Type: bugfix
Issue
The cart returned when items are removed from cart does not have the correct taxes.
Solution
Wait for the
afterCartUpdateupdates to finish before returning the cart to the client.My code changes are based on how
updateCartItemsQuantitymutation handled returning the updated cart.Breaking changes
None
Testing
Go to checkout with multiple items in cart. Enter a shipping address that will result to taxes and enter shipping method. Go back to cart page. Remove an item in the cart. See that the tax is updated in the summary.