Faster Jest integration tests #5549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
aldeed
commented
Sep 12, 2019
| if (process.env.JEST_MONGO) { | ||
| delete jestConfig.testEnvironment; | ||
| jestConfig.preset = "@shelf/jest-mongodb"; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Most of this file was auto-generated by Jest init. I moved our "jest" key from package.json into here and then added this conditional here to load the @shelf/jest-mongodb preset when JEST_MONGO env is set. The npm test scripts that need in-memory MongoDB running are updated with JEST_MONGO=1.
Contributor
Author
|
@bt3gl Did you |
because we have client unit tests Signed-off-by: Eric Dobbertin <[email protected]>
Contributor
|
After running on containers, using: 🛳-it! |
von-steinkirch
approved these changes
Sep 17, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: test
Issue
Jest integration tests are slow
Solution
jest-mongodbpackage. It does the same thing we were already doing, setting upmongodb-memory-server, but it does it in a way that can happen one time total rather than one time per test file.jest-mongodbpackage.Running locally, integration tests are 8x faster for me.
Breaking changes
None
Testing
npm run test:integrationand confirm it's faster