refactor: remove catalog/publish/products meteor method, use publishProductsToCatalog GQL Mutation instead
#5541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
@mikemurray @aldeed I messed something up big time while trying to get DCO to pass on #5528, so I'm closing that PR in favor of this one. It should be the same as the last one, with your comments all addressed. |
…future Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
requested changes
Sep 11, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
@kieckhafer Code looks good, but I did find one issue when testing. See inline comment.
imports/plugins/core/catalog/client/components/publishControls.js
Outdated
Show resolved
Hide resolved
Contributor
|
I'm not sure what's up with the integration tests failing on CI. Hopefully just a fluke. |
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
@aldeed updated Mutation to use callbacks. Tests seems to be passing again. |
aldeed
approved these changes
Sep 12, 2019
45 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement of #5528, which I messed up with some rebasing while trying to get DCO to pass.
Resolves parts of #5529
Impact: minor
Type: refactor
Issue
publishContainerandproductGridContainerstill use thecatalog/publish/productsmeteor method to publish products, which in turn usesgetGraphQLContextInMeteorMethod.Solution
Re-write anywhere that calls
catalog/publish/productsto use thepublishProuctsToCatalogmutation instead, remove thecatalog/publish/productsmeteor method, which will removegetGraphQLContextInMeteorMethodin this instance.Breaking changes
Any custom code that uses the
catalog/publish/productsMeteor method will need to be re-written to use thepublishProductsToCataloggraphql mutationTesting
catalog/publish/productsmeteor method has been removed