feat: add support for multilingual email #5556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldeed
requested changes
Sep 19, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
@jm18457 Overall this looks good, but a few comments to fix. You'll also need to merge in latest develop. @kieckhafer has been converting some of the email stuff to non-Meteor, so there may be some adjustments to make. Bad timing, sorry, but I'd like to get this one merged.
imports/plugins/core/accounts/server/no-meteor/schemas/account.graphql
Outdated
Show resolved
Hide resolved
imports/plugins/core/accounts/server/no-meteor/schemas/account.graphql
Outdated
Show resolved
Hide resolved
imports/plugins/core/accounts/server/util/sendVerificationEmail.js
Outdated
Show resolved
Hide resolved
imports/plugins/core/orders/server/no-meteor/util/sendOrderEmail.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Jaka Maver <[email protected]>
…order Signed-off-by: Jaka Maver <[email protected]>
Signed-off-by: Jaka Maver <[email protected]>
Signed-off-by: Jaka Maver <[email protected]>
Signed-off-by: Jaka Maver <[email protected]>
Contributor
Author
|
I have misread your comment and rebased, instead of merging develop branch. |
aldeed
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5555
Impact: major
Type: feature
Issue
Previous pull request, which was closed due to significant changes in reaction in this timeframe and different forked repository.
Multilingual emails by shop are not supported, because email language will always be that of
shop.language. All users will receive email in same language.Solution
Added fields
profile.languageto Accounts collection andordererPreferredLanguageto order collection.Updated graphql queries and mutations to allow for optional language.
This way storefront can supply language and we support multilingual emails.
Breaking changes
No breaking changes.
Testing
Tests are not implemented, but code is tested locally.
Account Profile Language
setAccountProfileLanguage.Order language
orderPreferredLanguagefield.Account Emails