Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Sep 16, 2019

Resolves parts of #5529
Impact: minor
Type: feat|refactor

Issue

accounts/sendResetPasswordEmail was a meteor method which used getGraphQLContextInMeteorMethod.

Solution

Rewrite the meteor method to be a sendResetAccountPasswordEmail GraphQL mutation, which in turn will remove usage of getGraphQLContextInMeteorMethod.

Breaking changes

Any custom code which used the accounts/sendResetPasswordEmail meteor method will need to be updated to use the GraphQL mutation

Testing

  1. Set up the email settings inside Reaction Admin so you receive account related emails
  2. Sign up for a Reaction account, with a valid email address.
  3. Use the "Forgot password" form to reset your password
  4. See that you get the email (you'll need to set up storefrontUrls in your shop settings in order to actually reset the password)
  5. Enter an email address that isn't attached to an account
  6. See you receive an error message

Copy link
Contributor

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

I requested to reset my password via this UI: Screen Shot 2019-09-17 at 2 06 50 PM

And got this email: Screen Shot 2019-09-17 at 2 07 42 PM

@aldeed aldeed merged commit d97a74f into develop Sep 18, 2019
@aldeed aldeed deleted the refactor-kieckhafer-removeSendResetPasswordEmailMeteorMethod branch September 18, 2019 21:12
@aldeed aldeed mentioned this pull request Sep 23, 2019
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants