refactor: remove Reaction.Email #5559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
approved these changes
Sep 16, 2019
Merged
45 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves parts of #5529
Impact: breaking|minor
Type: refactor
Issue
Reaction.Email was deprecated in February of 2019, over 7 months ago, and prior to our
v2.0.0release. This is one of the last pieces of code that usesgetGraphQLContextInMeteorMethod, which we are removing.Solution
Given the time this has been deprecated since before
v2.0.0, and the fact that there are0instances of usingReaction.Emailinside core code, I believe this can be removed. It might be best to not merge until we make av3.0.0release branch, so it's included in the other breaking changes.Breaking changes
Any custom code using
Reaction.Emailwill need to be updated to callcontext.mutations.sendEmail.Testing