Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Sep 13, 2019

Resolves parts of #5529
Impact: minor
Type: refactor

Issue

As part of the removal of getGraphQLContextInMeteorMethod, we came across inviteShopOwner, which is no longer used by non marketplace.

Solution

Remove all code related to inviteShopOwner, which in turn removes one instance of getGraphQLContextInMeteorMethod

The test for this method was already removed here: 91cba49

Breaking changes

Any custom marketplace code calling inviteShopOwner will break.

Testing

  1. Since this functionality was no longer present in the UI, just starting the app and seeing it works should be sufficient.

…isn't allowed at this time

Signed-off-by: Erik Kieckhafer <[email protected]>
@aldeed aldeed merged commit 8ca3e83 into develop Sep 16, 2019
@aldeed aldeed deleted the refactor-kieckhafer-removeInviteShopOwner branch September 16, 2019 14:11
@kieckhafer kieckhafer mentioned this pull request Sep 18, 2019
@aldeed aldeed mentioned this pull request Sep 23, 2019
45 tasks
@kieckhafer kieckhafer mentioned this pull request Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants