Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature|bugfix
Changes
Resolves a few small issues that have come up recently.
fulfillmentTypesfield on theFulfillmentMethodtype to always be["shipping"]. You will not notice any difference here because it is always["shipping"]in the database for now, too, but this fix allows exploration of supporting other fulfillment types such as "pickup" or "digital".CommonOrderpassed to many different types of plugin calculation functions now hasaccountIdset on it if the source cart or order belongs to an account. This allows you to do pricing, shipping options, discounts, surcharges, etc. based on which account is placing the order.context.requestHeaders. We now remove theauthorization,cookie, andmeteor-login-tokenheaders, which contain sensitive information, from this object as a precaution.Breaking changes
None, unless you have a custom plugin relying on the headers that were removed from
context.requestHeaders, which is unlikely.Testing
fulfillmentTypeschange does not need testing.accountId, but you can temporarily logcommonOrder.accountIdsomewhere to verify that it is set as you go through checkout while logged in.context.requestHeadersin any resolver, and make a GraphQL request that will call that resolver, passing authorization header with your request. Verify that no headers with sensitive information are logged.