Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add extra field to the error message #5574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kieckhafer merged 1 commit into from
Sep 23, 2019
Merged

Add extra field to the error message #5574

kieckhafer merged 1 commit into from
Sep 23, 2019

Conversation

@impactmass
Copy link
Contributor

@impactmass impactmass commented Sep 20, 2019

Resolves: N/A
Impact: minor
Type: chore

Issue

Following comments on #5505, the error message from the function will be helpful if it shows the template name. That way a dev can track the missing template.

kieckhafer
kieckhafer approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer
Copy link
Member

kieckhafer commented Sep 23, 2019

I think this looks good.

I think there could be a reason to check for templateName as well, maybe earlier in the function, however if the templateName is undefined, the error message will be No email template undefined found for language ${language}, so that'll give an indication you need to pass it anyway.

@impactmass
Copy link
Contributor Author

impactmass commented Sep 23, 2019 •
edited
Loading

Thanks. I agree with your later point: if it's undefined, the error message will still shows it, and then can be fixed where the function was called.

@kieckhafer kieckhafer merged commit 859b2c4 into develop Sep 23, 2019
@kieckhafer kieckhafer deleted the impactmass-error-line-fix branch September 23, 2019 17:21
@kieckhafer kieckhafer mentioned this pull request Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@impactmass @kieckhafer