Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mikemurray
Copy link
Member

Resolves #5576
Impact: critical
Type: bugfix

Issue

  • Couldn't delete meta fields
  • "new metafield" wouldn't clear input on save

Solution

  • Fix issue of not being able to delete by adding the meteor call to the callback, rather than relying on props

Breaking changes

none.

Testing

  1. Go to a product
  2. Add meta fields
  3. See that that the input fields are now cleared on submit
  4. Remove meta fields and see that it works as expected

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works as described

@kieckhafer kieckhafer merged commit d8f24c1 into develop Sep 26, 2019
@kieckhafer kieckhafer deleted the fix-5576-mikemurray-product-metadata branch September 26, 2019 23:28
@kieckhafer kieckhafer mentioned this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants