Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Sep 26, 2019

Impact: minor
Type: refactor

As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective /imports/plugins/{package}/server/no-meteor/ folders into their new /node-app/plugins/{package} folder.

Updates also include future-proofing some existing code, including adding filetype extensions (and index.js to imports)

Breaking changes

Any custom plugins that import files directly from the system-information package will need to be updated.

Testing

  1. Start the application and see that it works as it should.
  2. Test any GraphQL functionality that has been moved in this process, such as:
query {
  systemInformation(shopId: "SHOP_ID") {
    apiVersion
  }
}

@kieckhafer kieckhafer requested a review from aldeed September 26, 2019 21:15
@aldeed aldeed merged commit c5d26de into develop Sep 26, 2019
@aldeed aldeed deleted the refactor-kieckhafer-movePackageToNodeApp-systemInformation branch September 26, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants