Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Sep 26, 2019

Resolves #5627
Impact: minor
Type: refactor

As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective /imports/plugins/templates/server/no-meteor/ folders into their new /node-app/plugins/templates folder.

Updates also include future-proofing some existing code, including adding filetype extensions (and index.js to imports)

Breaking changes

Any custom plugins that import files directly from the templates package will need to be updated.

Testing

  1. Start the application and see that it works as it should.
  2. See that the Templates collection is registered in context.collections

@kieckhafer kieckhafer changed the title refactor: move template from server/no-meteor to node-app refactor: move template from server/no-meteor to node-app Sep 27, 2019
@aldeed aldeed self-requested a review September 30, 2019 19:57
@aldeed aldeed merged commit 30d91ca into develop Sep 30, 2019
@aldeed aldeed deleted the refactor-kieckhafer-movePackageToNodeApp-templates branch September 30, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants