Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Sep 27, 2019

Resolves #5589
Impact: minor
Type: refactor

As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective /imports/plugins/address/server/no-meteor/ folders into their new /node-app/plugins/address`` folder.

Updates also include future-proofing some existing code, including adding filetype extensions (and index.js to imports)

Breaking changes

Any custom plugins that import files directly from the address package will need to be updated.

Testing

  1. Start the application and see that it works as it should.
  2. Test any GraphQL mutation that has been moved in this process, such as:
query {
  addressValidation(address: {AddressInput}, shopId: "SHOP_ID") {
    suggestedAddresses
    validationErrors
  }
}

@kieckhafer kieckhafer changed the title refactor: move address from server/no-meteor to node-app refactor: move address from server/no-meteor to node-app Sep 27, 2019
@kieckhafer kieckhafer merged commit 815826b into develop Sep 30, 2019
@kieckhafer kieckhafer deleted the refactor-kieckhafer-movePackageToNodeApp-address branch September 30, 2019 20:38
This was referenced Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants