refactor: use reaction-error external package instead of internal alias
#5631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lias Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
approved these changes
Sep 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature|refactor
We've moved
ReactionErrorinto it's own npm package (https://github.com/reactioncommerce/reaction-error). This PR updatesreactioncode to install this new package, instead of using an alias for an internal file.Since we have been using the alias, no changes will need to be made throughout the app, just replacing the alias with an installed package.
Breaking changes
Any code that directly called /imports/utils/ReactionError.js` will need to be updated to use this alias.
Testing
Publishto catalog before filling in any data. You should see a Toast alert.