-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor: move shipping and surcharges from server/no-meteor to node-app
#5632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move shipping and surcharges from server/no-meteor to node-app
#5632
Conversation
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
shipping and surcharges from server/no-meteor to node-app
Signed-off-by: Erik Kieckhafer <[email protected]>
shipping and surcharges from server/no-meteor to node-appshipping and surcharges from server/no-meteor to node-app
…r-movePackageToNodeApp-surcharges
…pToCommonOrder Signed-off-by: Erik Kieckhafer <[email protected]>
|
@aldeed there is a new query created here, so this is a bit more in depth than just moving files between packages, please double check the new |
…e published) Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
shipping and surcharges from server/no-meteor to node-appshipping and surcharges from server/no-meteor to node-app
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…group Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
imports/plugins/core/cart/server/no-meteor/queries/getCommonOrderForCartGroup.js
Show resolved
Hide resolved
imports/plugins/core/cart/server/no-meteor/queries/getCommonOrderForCartGroup.js
Show resolved
Hide resolved
| cartId: decodeCartOpaqueId(cartId), | ||
| fulfillmentGroupId: decodeFulfillmentGroupOpaqueId(fulfillmentGroupId) | ||
| }); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not being clear. I don't think it's a good idea to have this query in GraphQL. It should be for internal use only. Maybe this would change at some point but for now CommonOrder is more of an internal concept among plugins that doesn't need to be part of the GraphQL schema.
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
|
@aldeed comments addressed |
Signed-off-by: Erik Kieckhafer <[email protected]>
Resolves #5620 & #5618
Impact: minor
Type: refactor
As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective
/imports/plugins/*/server/no-meteor/folders into their new/node-app/{core-services|plugins}/*folder.Updates also include future-proofing some existing code, including adding filetype extensions (and
index.jsto imports)This PR moves both the
shippingandsurchargespackages, assurchargesrelies onshipping.Breaking changes
Any custom plugins that import files directly from the
addresspackage will need to be updated.Testing