refactor: move email-smtp from server/no-meteor to node-app #5641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
kieckhafer
reviewed
Oct 2, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
One suggestion to use the new alias which will be the new api-utils package eventually, but code looks good aside from that.
imports/node-app/plugins/email-smtp/mutations/verifySMTPEmailSettings.test.js
Outdated
Show resolved
Hide resolved
…SMTPEmailSettings.test.js Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…hub.com:/reactioncommerce/reaction into refactor-aldeed-movePackageToNodeApp-email-smtp
This was referenced Oct 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5601
Impact: minor
Type: refactor
As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective
/imports/plugins/*/server/no-meteor/folders into their new/node-app/{core-services|plugins}/*folder.Updates also include future-proofing some existing code, including adding filetype extensions (and
index.jsto imports)Breaking changes
Any custom plugins that import files directly from the
email-smtppackage will need to be updated.Testing