Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Oct 4, 2019

Resolves #5623
Impact: minor
Type: refactor

As part of our effort to separate our Reaction Admin from our Reaction Node API, we are moving our GraphQL services from their respective /imports/plugins/*/server/no-meteor/ folders into their new /node-app/{core-services|plugins}/* folder.

Updates also include future-proofing some existing code, including adding filetype extensions (and index.js to imports)

Breaking changes

Any custom plugins that import files directly from the marketplace package will need to be updated.

Testing

  1. Start the application and see that marketplace shows up in shop settings and Marketplace Stripe payment service shows up in Payment settings.

@aldeed aldeed requested a review from kieckhafer October 4, 2019 02:34
@aldeed aldeed self-assigned this Oct 4, 2019
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit 5b38538 into develop Oct 4, 2019
@kieckhafer kieckhafer deleted the refactor-aldeed-movePluginToNodeApp-marketplace branch October 4, 2019 04:04
@willopez willopez mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants