refactor: move getPaymentMethodConfigByName to context #5684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
@aldeed Is there a way to do |
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
requested changes
Oct 7, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
@kieckhafer Instead of using rewire you'd just mock the function on context now. Something like
mockContext.queries.getPaymentMethodConfigByName = jest.fn().mockName("getPaymentMethodConfigByName").mockImplementation(() => ({
functions: {
listRefunds: async () => [{
_id: "refundId",
type: "refund",
amount: 19.99,
currency: "usd"
}]
}
}));One other comment, too.
| @@ -0,0 +1,14 @@ | |||
| const paymentMethods = {}; | |||
Contributor
There was a problem hiding this comment.
This needs to be import { paymentMethods } from "../registration.js"; because the function that sets them into this list is in that file.
…r-move-getPaymentMethodConfigByName-to-context
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
@aldeed updated to use the |
aldeed
approved these changes
Oct 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5653
Impact: minor
Type: feature|refactor
Issue
getPaymentMethodConfigByNamewas used across many pluginsSolution
For the sake of keeping our plugins contained, we are adding this method,
getPaymentMethodConfigByNameto thecontextto use instead of importing from thepaymentspackage directly.Breaking changes
Any custom code which uses
getPaymentMethodConfigByNameby direct import will need to update to use thecontext.queries.getPaymentMethodConfigByNameinsteadTesting