chore: clean-up tasks related to moving files to the node-app #5688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ils` to use ``@reactioncommerce/api-utils/graphql/` Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…r-movePackageToNodeApp-cleanupTasks
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
requested changes
Oct 7, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
Add back everything in graphql plugin utils and add back the @reactioncommerce/reaction-graphql-utils module resolution to there. That way we can avoid a breaking change until the 3.0 branch.
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
@aldeed util files and module resolver added back. Ready for another look. |
aldeed
approved these changes
Oct 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature|style|refactor|chore
Various clean-up tasks related to our moving of files from their respective
no-meteorfolders to thenode-app.mockContextimports are updated to be from the newapi-utilspackagehashLoginTokentohashToken, move it to theapi-utilspackage, and update all imports@reactioncommerce/reaction-graphql-utilsare now importing from@reactioncommerce/api-utils/graphql/*Still to do (in other PRs)
appEventsisn't called in Meteor code: https://github.com/reactioncommerce/reaction/issues/5691Breaking changes
hashLoginTokenwill need to update to usehashTokenfrom@reactioncommerce/api-utils/graphql/@reactioncommerce/reaction-graphql-utilswill need to update to use the import from@reactioncommerce/api-utils/graphql/insteadTesting