fix: pass correct userId when creating a shop #5694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement PR for #5377
Resolves #5376
Impact: minor
Type: bugfixrefactor
Issue
Solution
If we create a new owner user with this new shop, we want to update this new owner user, not the existing "admin" user, in the
afterShopCreateappEvent. By passing the secondIDfield, we can determine if this is the new user, or the existing admin, and update the correct account.Breaking changes
None
Testing