Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(ordersByAccountId): add graphql integration test #5696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aldeed merged 16 commits into from
Oct 28, 2019
Merged

test(ordersByAccountId): add graphql integration test #5696

aldeed merged 16 commits into from
Oct 28, 2019

Conversation

@machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Oct 7, 2019 •
edited
Loading

Resolves #5690
Impact: minor
Type: tests

Issue

No tests for ordersByAccountId

Solution

Add tests for ordersByAccountId:

  • successfully return 1 order
  • successfully return 10 orders
  • successfully return orders with a specific order status
  • invalid param error

Breaking changes

none

Testing

docker-compose run --rm reaction yarn run test:file tests/integration/api/queries/ordersByAccountId/ordersByAccountId.test.js

@machikoyasuda machikoyasuda changed the base branch from master to develop October 7, 2019 23:54
@machikoyasuda machikoyasuda force-pushed the test-machiko-orderbyaccountid branch from bcb1bd6 to 15c68e4 Compare October 8, 2019 20:22
@machikoyasuda machikoyasuda marked this pull request as ready for review October 9, 2019 00:40
mpaktiti
mpaktiti approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@mpaktiti mpaktiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Machiko Yasuda added 3 commits October 11, 2019 10:03
tests(ordersByAccountId): delete Shop too
ccc8eb8 
Signed-off-by: Machiko Yasuda <[email protected]>
chore: lint
81762d0 
Signed-off-by: Machiko Yasuda <[email protected]>
chore: lint
be60022 
Signed-off-by: Machiko Yasuda <[email protected]>
@machikoyasuda machikoyasuda changed the base branch from develop to release-3.0.0 October 17, 2019 20:49
@aldeed aldeed changed the base branch from release-3.0.0 to develop October 21, 2019 18:31
aldeed
aldeed requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but one suggestion that I think will make one test stronger.

@aldeed aldeed mentioned this pull request Oct 21, 2019
Merged
@machikoyasuda machikoyasuda force-pushed the test-machiko-orderbyaccountid branch from 58a469a to 5019430 Compare October 24, 2019 21:41
chore: lint
f5abe38 
Signed-off-by: Machiko Yasuda <[email protected]>
@machikoyasuda
Copy link
Contributor Author

machikoyasuda commented Oct 24, 2019

@chrispotter @aldeed Thanks for the code reviews! I resolved both issues and everything is green.

@machikoyasuda machikoyasuda requested a review from aldeed October 24, 2019 23:38
@machikoyasuda machikoyasuda changed the base branch from develop to release-3.0.0 October 25, 2019 04:20
@machikoyasuda machikoyasuda changed the base branch from release-3.0.0 to develop October 25, 2019 04:21
@chrispotter
Copy link

chrispotter commented Oct 25, 2019

great job @machikoyasuda!

@machikoyasuda
Copy link
Contributor Author

machikoyasuda commented Oct 28, 2019

@aldeed Should this PR go into develop or release-3.0?

@aldeed
Copy link
Contributor

aldeed commented Oct 28, 2019 •
edited
Loading

@machikoyasuda Yes develop. After we get them all into develop I'll do one PR copying them all into 3.0.0 branch.

@aldeed aldeed merged commit 11d1e9a into develop Oct 28, 2019
@aldeed aldeed deleted the test-machiko-orderbyaccountid branch October 28, 2019 21:15
This was referenced Oct 31, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kieckhafer kieckhafer kieckhafer left review comments

@chrispotter chrispotter chrispotter left review comments

@aldeed aldeed aldeed approved these changes

@mpaktiti mpaktiti mpaktiti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@machikoyasuda @chrispotter @aldeed @kieckhafer @mpaktiti