Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Fix] Create and Delete navigation item mutations #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aldeed merged 6 commits into from
Nov 13, 2019
Merged

[Fix] Create and Delete navigation item mutations #5715

aldeed merged 6 commits into from
Nov 13, 2019

Conversation

@trojanh
Copy link
Contributor

@trojanh trojanh commented Oct 10, 2019

Resolves none
Impact: breaking
Type: bugfix

Issue

Creating Navigation Item from Reaction Admin UI breaks for anyone other than the owner.

Solution

Supplying shopId to userHasPermission fixes the above issue and the non-owner user is able to add the NavigationItem.

Breaking changes

Steps to reproduce:

  1. Login as Shop Manager or someone who has core permission but not as an Owner
  2. Go to Navigation page and try adding a new Navigation Item
  3. You will see the form to add the NavigationItem and after saving the item the NavigationItem doesn't appear in the list.

This works fine for the Owner. The problem was the method was called with a missing parameter for
userHasPermission which also expects roleGroup parameter which is shopId for us.

Testing

  1. Login as Shop Manager or someone who has core permission but not as an Owner
  2. Go to Navigation page and try adding a new Navigation Item
  3. You will see the form to add the NavigationItem and after saving the item the NavigationItem appears on the list.

@trojanh trojanh force-pushed the develop branch 2 times, most recently from a745646 to d513593 Compare October 10, 2019 11:18
@trojanh
Copy link
Contributor Author

trojanh commented Oct 10, 2019

I think navigationTreeById query should also have shopId parameter here

reaction/imports/node-app/plugins/navigation/queries/navigationTreeById.js

Line 24 in da25e65

const isAdmin = userHasPermission(["admin", "owner", "create-product"]);

@spencern spencern requested a review from mikemurray October 10, 2019 19:13
mikemurray
mikemurray approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Failing tests look unrelated/happening to a bunch of other open PR's

@trojanh
Copy link
Contributor Author

trojanh commented Oct 11, 2019

Thanks, @mikemurray for reviewing my PR, let me know if I could do anything to fix the failing tests.

@aldeed
Copy link
Contributor

aldeed commented Oct 22, 2019

@trojanh Thank you. Can you merge latest develop into this branch? That should fix the CI tests and allow us to be sure this doesn't break anything, but otherwise the code changes look good.

@aldeed
Copy link
Contributor

aldeed commented Oct 28, 2019

@trojanh Ping. See my comment above.

@trojanh
Copy link
Contributor Author

trojanh commented Oct 29, 2019

Sorry for the delay @aldeed it was Diwali so couldn't revert back, appreciate the reminder though. I have pulled the latest develop branch so it should fix the issue.

@garyrvaz garyrvaz mentioned this pull request Nov 1, 2019
Merged
@aldeed aldeed merged commit 3c5238d into reactioncommerce:develop Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikemurray mikemurray mikemurray approved these changes

@aldeed aldeed aldeed approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trojanh @aldeed @mikemurray @machikoyasuda