refactor: only update fulfillment group for which id is provided #5723
Conversation
Signed-off-by: Gary Ryan Vaz <[email protected]>
|
Thank you for the contribution @Yuuwaku |
|
Happy to assist @aldeed |
|
Hi @Yuuwaku - I am going to revert this PR for now because the integration test is failing: https://circleci.com/gh/reactioncommerce/reaction/59315 Could you please look into this and make a new PR? |
|
Hey @machikoyasuda I see that the test for updateOrderFulfillmentGroup is passing in the link you mentioned. The integration tests seem to fail due to user permissions in other tests that are not related to these changes. And the only change here is to implement arrayFilters. |
|
@machikoyasuda also, at the time I raised this PR, there were other PRs as well that had failure in tests which was identified here: #5715 (review) |
|
@Yuuwaku Hi! Thanks for your swift reply! We're looking into this. We won't revert this PR most likely. Still trying to find where the tests are failing. |
|
@machikoyasuda from what I found out while researching regarding the integration tests timing out, is that it is due to an issue with jest using one worker in --runInBand. Here are some references that may be helpful with the issue. |
|
@Yuuwaku Thank you. I closed the revert PR. Adding maxWorkers=3 and removing runInBand fixed the tests so we’re all good now. |
Impact: minor
Type: refactor
Issue
If there are more than one fulfillment groups, this mutation will update the workflow of all the groups.
Solution
Adding arrayFilters to the collection update to make sure only the group, for which the id is provided, gets updated. Had to remove the schema modifier validation due to this: Meteor-Community-Packages/meteor-collection2#387
Breaking changes
none
More detail for what each of these sections should include are available in our Contributing Docs