fix: password-reset route not working correctly #5744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
3 tasks
mikemurray
requested changes
Oct 30, 2019
Member
mikemurray
left a comment
There was a problem hiding this comment.
I can see the reset password page, but cannot reset the password. The form hangs with a spinner forever after submitting it. The error I get is below.
errorClass {message: "Match error: Expected string, got undefined", path: "", sanitizedError: errorClass, errorType: "Match.Error", stack: "Error: Match error: Expected string, got undefined…4032cc20b589152bd2e905ef16f0748d26b2fa4:198317:5)"}
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
@mikemurray can you recheck this please? |
mikemurray
requested changes
Nov 6, 2019
Member
mikemurray
left a comment
There was a problem hiding this comment.
Reset seems to work, but I'm being redirected to a white screen with no console errors. I have the storefront urls set for both homepage and login url.
| throw new ReactionError("error-occurred", "Missing storefront URLs. Please set these properties from the shop settings panel."); | ||
| } else { | ||
| window.location.href = storefrontUrls.storefrontLoginUrl; | ||
| Router.go(storefrontUrls.storefrontLoginUrl); |
Member
There was a problem hiding this comment.
This should still probably be window.location.href you're redirecting to a different site. Router.go is really only for push state within this app context.
Signed-off-by: Erik Kieckhafer <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5726
Impact: critical
Type: bugfix
Issue
The reset-password route does not correctly render the right component, making it impossible for you to reset your password unless you are under certain circumstances, like an admin who is logged in.
In addition, there was an issue related to this Password reset being a GQL mutation. On this page, there is no user, so
meteor-login-tokenis not set. However, we were setting that value tonull, instead of leaving it undefined. GQL was trying to usenullas an auth check, which was throwingUnauthorizederrors.By leaving the
meteor-login-tokenas undefined, we are able to use this mutation without being logged in /null.Solution
reset-password, and show the form if it is.meteor-login-tokenis a value orundefined, but notnullNotes
This does not fix the underlying problem, which is that the
reset-passwordroute doesn't register as it should and instead saysnot-foundfor thenameof the route. It provides a temporary fix to the issue we are seeing until we can move authentication to it's own app.Breaking changes
None.
Testing