fix: remove check for shopId where not needed #5895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
manueldelreal
approved these changes
Dec 11, 2019
Member
manueldelreal
left a comment
There was a problem hiding this comment.
I can create the shop now via the admin
Signed-off-by: Erik Kieckhafer <[email protected]>
rosshadden
approved these changes
Dec 11, 2019
aldeed
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5894
Impact: major
Type: **bugfix
Issue
When creating the first shop, we don't have a shopID yet, so the check against the shopID was failing.
Solution
Don't require shopId, and let the rest of the checks take care of this.
Breaking changes
None
Testing