Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upgrade mongodb and jest-mongodb #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willopez merged 3 commits into from
Dec 26, 2019
Merged

Upgrade mongodb and jest-mongodb #5904

willopez merged 3 commits into from
Dec 26, 2019

Conversation

@trojanh
Copy link
Contributor

@trojanh trojanh commented Dec 12, 2019

Resolves N.A
Impact: minor
Type: chore

Issue

Upgrade mongodb minor version to resolve the following warning

DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.

ref: jira-comment

Upgardes jest-mongodb to minor version: jest-mongodb

@trojanh trojanh changed the title Upgrade mongodb and Upgrade mongodb and jest-mongodb Dec 12, 2019
@trojanh trojanh marked this pull request as ready for review December 17, 2019 17:06
@willopez willopez self-requested a review December 17, 2019 17:13
willopez
willopez reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change needed.

package.json Outdated
"@reactioncommerce/data-factory": "~1.0.1",
"@reactioncommerce/eslint-config": "~2.1.0",
"@shelf/jest-mongodb": "~1.1.2",
"@shelf/jest-mongodb": "^1.1.3",
Copy link
Member

@willopez willopez Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our patter is to use the tilde ~, please change it.

@trojanh trojanh requested a review from willopez December 18, 2019 06:40
@trojanh
Copy link
Contributor Author

trojanh commented Dec 23, 2019

I have made all the changes @willopez , please review this PR when you have some time.

willopez
willopez approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez merged commit 09447cb into reactioncommerce:release-3.0.0 Dec 26, 2019
@rosshadden rosshadden mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willopez willopez willopez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trojanh @willopez