test: fix out-of-memory issues in tests #5918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split query and mutation integration tests and increase the memory limit of both. This isn't a permanent fix for the out-of-memory issues, but it does buy us some time to figure out a proper solution. Signed-off-by: Mike Murray <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5897
Impact: critical
Type: test
Issue
Integration tests are failing due to a memory leak. Unit tests are also slightly affected but they only ever reach 100mb heap size, so well below the memory limit.
Solution
Split query and mutation integration tests and increase the memory limit of both. This isn't a permanent fix for the out-of-memory issues, but it does buy us some time to figure out a proper solution.
Breaking changes
none;
Testing