Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Dec 14, 2019

Impact: minor
Type: refactor

Changes

  • Move address from plugins to core-services because it is core
  • Several plugins were carried over from 2.x but now contain only translations. This merges all translations from those plugins into a single new plugin named reaction-translations. These translations are used by the Reaction Admin project. The following plugins are thus deleted:
    • src/core-services/core
    • src/plugins/checkout
    • src/plugins/dashboard
    • src/plugins/product-admin
    • src/plugins/product-variant
    • src/plugins/templates
    • src/plugins/ui

The templates plugin also defined the Templates MongoDB collection, but since that collection is only used by the email-templates plugin, I moved it there.

Breaking changes

Some plugins are removed but since they contained only translations and those translations are still present in the new plugin, it's unlikely this will break anything.

Testing

@aldeed aldeed force-pushed the feat-aldeed-3.0-plugin-consolidate branch from a3ada17 to e3f57d6 Compare December 14, 2019 21:19
@aldeed aldeed requested a review from mikemurray December 14, 2019 21:20
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 929f55c into release-3.0.0 Dec 16, 2019
@mikemurray mikemurray deleted the feat-aldeed-3.0-plugin-consolidate branch December 16, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants