refactor: clean up ENV/envalid code #5922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5921
Impact: minor
Type: refactor
Changes
envalidto check them on startup rather than accessingprocess.envdirectly. I've updated everything to use this pattern.envalid.cleanEnvcalls listed variables that were no longer used by any code. Removed them.NODE_ENVwas "jesttest". In the old Meteor app, "jesttest" was used when integration tests ran. It was a workaround that is no longer needed, and integration tests have been running withNODE_ENVset to the default of "test" for some time, so I updated the checks to look for "test".Breaking changes
None
Testing
Verify the app starts up and anything else you think needs testing