Return fulfillment quotes without a shipping address #5934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
kieckhafer
approved these changes
Dec 19, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
Looks good.
Was able to get fulfillment quote attached to the cart via the API prior to adding an address to an order, and was able to get that method restricted based on an attribute restriction.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5472
Impact: minor
Type: feature
Changes
The
getFulfillmentMethodsWithQuotesfunction in theshipping-ratesplugin now looks up shipping rates and applies shipping restrictions as much as it can when there is noshippingAddresson the order/cart yet. Previously it would throw an error.Breaking changes
The behavior has changed, but not in a way that is likely to confuse anyone.
Testing
updateFulfillmentOptionsForGroupmutation before setting a shipping address on the cart and verify that shipping rates are added to the cart.