tests: Add integration tests for surcharge #5938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
ba170df to
f847982
Compare
Member
Contributor
Author
|
Sorry @mikemurray I had just checked the open PRs before starting this and later found that you already had similar issues assigned to yourself. I didn't mean to do overlapping work. If you haven't started working on the updateSurcharge test i dont mind completing it with this. |
Member
|
@trojanh It's ok, I assigned myself to it but didn't start working on it since other things popped up in priority. |
Signed-off-by: trojanh <[email protected]>
Contributor
Author
|
@mikemurray feel free to review this now whenever you can. I have added the test for updateSurcharge mutation |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5937 & #5923
Impact: minor
Type: test|chore
Issue
Add integration tests for createSurcharge, updateSurcharge and deleteSurcharge mutations