Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Dec 19, 2019

Resolves #4961
Resolves #5796
Resolves #4813
Impact: minor
Type: feature|bugfix

Issues

Solution

  • approveOrderPayments supports isInternalCall
  • Shop resolvers for fields that return connections work properly
  • The catalogItemProduct GraphQL query accepts an optional shopId argument that is recommended when looking up by slug
  • You can now set one defaultParcelSize field without needing to set the others

Breaking changes

None

Testing

Verify the described fixes. For the shop resolvers one, use this query with an admin token:

{
  primaryShop {
    _id
    name
    administrators {
      nodes {
        name
      }
    }
    tags {
      nodes {
        name
      }
    }
    roles {
      nodes {
        name
      }
    }
    groups {
      nodes {
        name
      }
    }
  }
}

@aldeed aldeed requested a review from mikemurray December 19, 2019 23:38
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez merged commit 3ff93ac into release-3.0.0 Dec 24, 2019
@willopez willopez deleted the fix-aldeed-minor-fixes-3.0 branch December 24, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants