fix: remove extra handling charge from fulfillment total
#5987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
… into release-2.9.1
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
@mikemurray this seems to be the appropriate fix for the price mismatch issue we were debugging. @aldeed mentioned he'd look into refactoring the names and confirming the calculations in the 3.0 branch, but you should probably update #5976 to include this change instead of this one. |
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
approved these changes
Dec 21, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
Didn't test but this looks like the correct fix based on code review
Signed-off-by: Eric Dobbertin <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: major
Type: bugfix
Issue
Total price mismatch between submitted payment and expected total when shipping includes a handling fee.
Solution
Remove extra
handlingcharge addition inaddInvoiceToGroupBreaking changes
No breaking changes
Testing