Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: add integration test for create, update & delete FlatRateFulfillmentRestriction mutations #5981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willopez merged 5 commits into from
Dec 26, 2019
Merged

test: add integration test for create, update & delete FlatRateFulfillmentRestriction mutations #5981

willopez merged 5 commits into from
Dec 26, 2019

Conversation

@trojanh
Copy link
Contributor

@trojanh trojanh commented Dec 20, 2019 •
edited
Loading

Signed-off-by: trojanh [email protected]

Resolves #5980
Impact: |minor
Type: test|chore

Issue

Add integration test for create, update & delete FlatRateFulfillmentRestriction mutation

@trojanh trojanh force-pushed the update-flat-rate-fulfillment-restriction-test branch from ea18378 to 1abb36e Compare December 20, 2019 13:06
@trojanh trojanh force-pushed the update-flat-rate-fulfillment-restriction-test branch from 1abb36e to 00918b7 Compare December 20, 2019 13:07
@trojanh trojanh force-pushed the update-flat-rate-fulfillment-restriction-test branch from 3199ed1 to 020686f Compare December 20, 2019 13:09
@trojanh trojanh changed the title test: add integration test for updateFlatRateFulfillmentRestriction mutation test: add integration test for create & update FlatRateFulfillmentRestriction mutation Dec 20, 2019
@trojanh trojanh changed the title test: add integration test for create & update FlatRateFulfillmentRestriction mutation test: add integration test for create & update FlatRateFulfillmentRestriction mutations Dec 20, 2019
@trojanh trojanh changed the title test: add integration test for create & update FlatRateFulfillmentRestriction mutations test: add integration test for create, update & delete FlatRateFulfillmentRestriction mutations Dec 20, 2019
@willopez willopez self-requested a review December 20, 2019 18:14
@aldeed aldeed mentioned this pull request Dec 20, 2019
Closed
69 tasks
willopez
willopez requested changes Dec 20, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes needed, otherwise looking good.

@trojanh trojanh force-pushed the update-flat-rate-fulfillment-restriction-test branch from 9225d98 to a364bef Compare December 21, 2019 06:52
@trojanh trojanh force-pushed the update-flat-rate-fulfillment-restriction-test branch from a364bef to 19e1e54 Compare December 21, 2019 06:54
@trojanh
Copy link
Contributor Author

trojanh commented Dec 21, 2019

@willopez thanks for the review comments. I have used Restriction factory now. Also, FlatRateFulfillmentMethod mutation tests were not using Factory, so I have raised another PR for the same #5988

willopez
willopez approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @trojanh

@willopez willopez merged commit d2ae06a into reactioncommerce:release-3.0.0 Dec 26, 2019
@rosshadden rosshadden mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willopez willopez willopez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trojanh @willopez