fix: fix default public password reset URL #5991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: bugfix
Issue
Default
REACTION_IDENTITY_PUBLIC_PASSWORD_RESET_URLenv variable value used whenNODE_ENVisdevelopmentdoesn't match the actual Reaction Identity URL.Solution
Updated URL to match Reaction Identity.
NOTE: In production environments, you will need to update the URL manually. The path part should be
/account/reset-password/TOKENBreaking changes
None
Testing
Test this with reactioncommerce/example-storefront#637. All instructions are in that pull request.