Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@trojanh
Copy link
Contributor

@trojanh trojanh commented Jan 28, 2020

Resolves #6051
Impact: critical
Type: bugfix

Issue

  • When any product is updated afterBulkInventoryUpdate event is emitted.
  • This, in turn, causes partialProductPublish to be called from inventoryStartup startup method. - partialProductPublish tries to update the catalog of products that are not published yet.
  • partialProductPublish fails with an error as catalogProduct could not be destructured from catalogItem at this line

Solution

If the Catalog is not found for productId in partialProductPublish then avoid processing further and return from the method.

Testing

  1. Update the inventory of the product which is not yet published.
  2. Make sure no errors are thrown when partialProductPublish method gets called.

@trojanh trojanh force-pushed the fix-partialProductPublish branch from 4a3f5da to 4f17e0d Compare January 28, 2020 09:37
@aldeed aldeed merged commit d09cdc4 into reactioncommerce:release-3.0.0 Jan 28, 2020
@kieckhafer kieckhafer mentioned this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants