Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Feb 1, 2020

Impact: minor
Type: bugfix

Issue

After a shop is created, shop account groups are created and the account that created it is added as a shop owner, so that they can then access things about that shop. This was being done with incorrect permissions and failing, thus resulting in not being able to do anything with a shop (query, mutate, whatever) after creating it.

Solution

Updated to call the account group mutations with internal context so they don't fail.

Breaking changes

None

Testing

  1. Start platform on a clean database
  2. Go to http://localhost:4080 (admin), and register a new user.
  3. Enter a shop name and create a shop.
  4. Go to other pages and verify that tables load, updating settings works, etc.

@aldeed aldeed requested a review from kieckhafer February 1, 2020 13:08
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit 6ba44a0 into release-3.0.0 Feb 2, 2020
@kieckhafer kieckhafer deleted the fix-aldeed-add-to-shop-groups branch February 2, 2020 07:04
@kieckhafer kieckhafer mentioned this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants