refactor: move accounts plugin to npm #6189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
37 tasks
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
focusaurus
previously approved these changes
Apr 9, 2020
Contributor
focusaurus
left a comment
There was a problem hiding this comment.
I didn't test locally but looks OK.
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
previously approved these changes
Apr 9, 2020
Contributor
aldeed
left a comment
There was a problem hiding this comment.
👍 App starts and viewer query works
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
approved these changes
Apr 9, 2020
This was referenced Apr 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5693
This PR removes the internal account plugin, and installs the new api-plugin-accounts as a replacement.
The code in that npm plugin is the same, so the expected outcome of this PR is seeing nothing different than how the app currently runs.
To test this, start a store and create an account from the UI.
This PR also adds the file
src/mockTypes.graphql. This is a temporary file and is being used to appease graphql linting while we move these packages out of reaction and into their own plugins. Because the types are no longer always registered internally in reaction. and instead in each plugin, we are sometimes seeing errors in linting that we won't see once these packges arepeerDependency'd with each other outside of the api.