Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tcheyne
Copy link

@tcheyne tcheyne commented Dec 30, 2015

Resolves #630

@CLAassistant
Copy link

CLA assistant check
You should sign our Contributor License Agreement in order to get your pull request merged.


Tucker Cheyne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account (for further information, click here).

@aaronjudd
Copy link
Contributor

Approved. The CI tests timed-out here, but are passing fine locally. Tested and looks good. 👍

@brent-hoover
Copy link
Collaborator

Approved: +1 for tests

aaronjudd pushed a commit that referenced this pull request Jan 5, 2016
Bug fix for issue 630 Router checks for selected variant before defaulting to req params.
@aaronjudd aaronjudd merged commit fe0b0f1 into reactioncommerce:development Jan 5, 2016
@aaronjudd aaronjudd removed the ready label Jan 5, 2016
@tcheyne tcheyne deleted the 630 branch January 9, 2016 19:39
newsiberian added a commit to newsiberian/reaction that referenced this pull request Jan 27, 2016
- fix few typos here and there;

- `cartTransform` methods refactored;
- added `getSummary` function;

- `products/updateVariants` removed. It is were
replaced by new `products/updateVariantsPosition`
method;

- variant sorting reworked;

- `schema.productVariant.index` from now will keep
the top-level variant list index;

- fix all broken tests. Added few new tests,
and removed few unnecessary tests;

- removed a lot of `this.unblock()`, because I think
this is not needed, maybe even bad for our cases;

- `minOrderQuantity` field added to productVariant
 schema, due to reactioncommerce#225;

- added `flushQuantity` function to update to zero
top-level variant quantity.

- added `getVariantQuantity` common function,
and the same called template method, which returns
the summary of all options if their exists;
- added `denormalize` function;
- added `isSoldOut` function;
- added `isLowQuantity` function;
- added `isBackorder` function;
All this new function is useful for denormalizing of
productVariant SS fields;

- `inventory/register`, `adjust` updated.
Implemented `initializeUnorderedBulkOp()` instead of
`batchInsert`;

- A lot of UI updates due to compatability with flattened model;

- revert changes from reactioncommerce#632;

- products fixture modified;

- `shopIdAutoValue` method modified. Now it is ignore
update operations;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants