implement tag filtration #875
Conversation
Resolves #846 Resolves #870 - ReactionProduct.getProductPriceRange().priceRange updated to return range, min, max. - denormalize function updated to add price range, min, max - PriceRange added to product schema - Add filtering to the tags, as originally conceived for #743 — allow for multiple tags in query params The format is: http://localhost:3000/reaction/tag/shop?price.min=100&price.max=200
this.stop isn’t mocked, but we’ll rerun with publication later
I’m on the fence about the debug statements, they could come in handy, but a Publications are the one thing that can really slow things down.. it’s probably a good practice to keep them as lean as possible.
|
This is now complete and ready for merge. All tests passing. |
| // set "0" if no variants in product. If all variants were removed. | ||
| const priceRange = ReactionCore.getProductPriceRange(id) || 0; | ||
| Object.assign(update, { price: priceRange }); | ||
| const priceObject = ReactionCore.getProductPriceRange(id) || 0; |
There was a problem hiding this comment.
this won't cause an issue if this isn't an object but an integer? (if it's 0)
There was a problem hiding this comment.
yeah, agreed the defaults should be removed.
- response should be object now
sorting is actually done here: Template.productGrid.helpers and needs to be refactored with position logic if we’re moving into publications
|
@aaronjudd I see in this PR has many ideas and some code from this PR #743 And question about price range attribute - do we still need it in DB in case that we can always make it on the fly from price min and max values? |
|
The goal of using denormalized price range inside doc is to get speed benefit from it. |
Resolves #846
Resolves #870
range, min, max.
code injection, integration with reaction-filtration #743
— allow for multiple tags in query params
The format is:
regex text search of title, description: