Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show no products, "no products found" on invalid tag #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brent-hoover merged 5 commits into from
Apr 12, 2016
Merged

Show no products, "no products found" on invalid tag #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b76016
Return no products rather than all products when a tag is invalid
brent-hoover Apr 8, 2016
d2de10d
When no products, show "No products found" text
brent-hoover Apr 8, 2016
cda80c3
Merge branch 'development' into brent-fix-issue-889
brent-hoover Apr 8, 2016
ebc77a5
fix indenting
jshimko Apr 12, 2016
177bdb7
Merge branch 'development' into brent-fix-issue-889
brent-hoover Apr 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/reaction-i18n/private/data/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@
"notFoundTitle": "Oops!",
"notFoundError": "Page not found.",
"productNotFound": "This product was not found.",
"loadMoreProducts": "Load more products"
"loadMoreProducts": "Load more products",
"noProductsFound": "No Products found"
},
"shopSettings": {
"general": "General",
Expand Down
16 changes: 13 additions & 3 deletions packages/reaction-product-variant/client/templates/products/productGrid/productGrid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,19 @@
<div class="container-main">
<div class="product-grid" data-event-category="grid" data-event-action="generic-click" data-event-label="product grid click">
<ul class="product-grid-list list-unstyled" id="product-grid-list">
{{#each products}}
{{> productGridItems}}
{{/each}}
{{#if products}}
{{#each products}}
{{> productGridItems}}
{{/each}}
{{else}}
<div class="row">
<div class="text-center">
<h3>
<span data-i18n="app.noProductsFound">No Products Found</span>
</h3>
</div>
</div>
{{/if}}
</ul>
</div>
</div>
Expand Down
4 changes: 4 additions & 0 deletions packages/reaction-product-variant/client/templates/products/productGrid/productGrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ Template.productGrid.onCreated(function () {
if (tag) {
tags = {tags: [tag._id]};
}
// if we get an invalid slug, don't return all products
if (!tag && slug) {
return;
}
const queryParams = Object.assign({}, tags, ReactionRouter.current().queryParams);
Meteor.subscribe("Products", Session.get("productScrollLimit"), queryParams);
});
Expand Down