Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typos in getReactionApps function #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brent-hoover merged 1 commit into from
Apr 19, 2016
Merged

Fix typos in getReactionApps function #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/reaction-core/client/helpers/apps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function getReactionApps(optionHash) {
//
for (key in options) {
if ({}.hasOwnProperty.call(options, key)) {
const value = options[key];
let value = options[key];
if (!(key === "enabled" || key === "name" || key === "shopId")) {
filter["registry." + key] = value;
registryFilter[key] = value;
Expand Down Expand Up @@ -157,7 +157,7 @@ function getReactionApps(optionHash) {
for (key in registryFilter) {
// make sure we're dealing with valid keys
if ({}.hasOwnProperty.call(registryFilter, key)) {
value = registryFilter[key];
let value = registryFilter[key];
Copy link
Collaborator

@brent-hoover brent-hoover Apr 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is redundant. You could just use registryFilter[key] in line 161

if (registry[key] === value) {
match += 1;
}
Expand Down