Thanks to visit codestin.com
Credit goes to github.com

Skip to content

proposed fix to assignRoles.js #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronjudd merged 2 commits into from
May 2, 2016
Merged

proposed fix to assignRoles.js #980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9403ea0
proposed fix to assignRoles.js
sngn Apr 24, 2016
14b19f7
codeclimate fixes
sngn Apr 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions packages/reaction-core/server/registry/assignRoles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ const getRouteName = (packageName, registryItem) => {
*/

ReactionRegistry.assignOwnerRoles = (shopId, pkgName, registry) => {
const defaultRoles = ["owner", "admin", "createProduct", "guest", pkgName];
const globalRoles = defaultRoles;
const defaultRoles = ["owner", "admin", "guest"];
let packageRoles = defaultRoles.slice();
packageRoles.push(pkgName);
let globalRoles = packageRoles.slice();

if (registry) {
// for each registry item define and push roles
Expand All @@ -51,22 +53,24 @@ ReactionRegistry.assignOwnerRoles = (shopId, pkgName, registry) => {
// todo: check dependency on this.
const roleName = getRouteName(pkgName, registryItem);
if (roleName) {
defaultRoles.push(roleName);
packageRoles.push(roleName);
}

// Get all defined permissions, add them to an array
// define permissions if you need to check custom permission
if (registryItem.permissions) {
for (let permission of registryItem.permissions) {
defaultRoles.push(permission.permission);
packageRoles.push(permission.permission);
}
}
}
} else {
ReactionCore.Log.debug(`No routes loaded for ${pkgName}`);
}
// only unique roles
const defaultOwnerRoles = _.uniq(defaultRoles);
packageRoles = _.uniq(packageRoles);
// globalRoles = _.uniq(globalRoles);
const defaultOwnerRoles = ["owner"];
// get existing shop owners to add new roles to
const owners = [];
const shopOwners = Roles.getUsersInRole(defaultOwnerRoles).fetch();
Expand All @@ -80,7 +84,7 @@ ReactionRegistry.assignOwnerRoles = (shopId, pkgName, registry) => {
owners.push(account._id);
}
// we don't use accounts/addUserPermissions here because we may not yet have permissions
Roles.addUsersToRoles(owners, defaultOwnerRoles, shopId);
Roles.addUsersToRoles(owners, packageRoles, shopId);

// the reaction owner has permissions to all sites by default
Roles.addUsersToRoles(owners, globalRoles, Roles.GLOBAL_GROUP);
Expand Down