Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #983 bug with shipmentMethod undefined #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronjudd merged 1 commit into from
May 3, 2016
Merged

Fix #983 bug with shipmentMethod undefined #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/reaction-collections/common/collections/collections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ ReactionCore.Helpers.cartTransform = {
},
cartShipping: function () {
// loop through the cart.shipping, sum shipments.
return parseFloat(getSummary(this.shipping, ["shipmentMethod", "rate"]));
// shipmentMethod could be undefined if we resets workflow from more higher
// stage by adding new item to cart for example
if (typeof this.shipping[0].shipmentMethod === "object") {
return parseFloat(getSummary(this.shipping, ["shipmentMethod", "rate"]));
}
return 0;
},
cartSubTotal: function () {
return getSummary(this.items, ["quantity"], ["variants", "price"]).
Expand All @@ -62,7 +67,10 @@ ReactionCore.Helpers.cartTransform = {
cartTotal: function () {
let subTotal = getSummary(this.items, ["quantity"], ["variants", "price"]);
// loop through the cart.shipping, sum shipments.
let shippingTotal = getSummary(this.shipping, ["shipmentMethod", "rate"]);
let shippingTotal = 0;
if (typeof this.shipping[0].shipmentMethod === "object") {
shippingTotal = getSummary(this.shipping, ["shipmentMethod", "rate"]);
}
shippingTotal = parseFloat(shippingTotal);
// TODO: includes taxes?
if (typeof shippingTotal === "number" && shippingTotal > 0) {
Expand Down