Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed broken dashboard labels #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brent-hoover merged 1 commit into from
May 24, 2016
Merged

Fixed broken dashboard labels #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/reaction-dashboard/client/templates/dashboard/settings/settings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
<div class="nav-settings-heading">
<h3 class="nav-settings-title">
{{#with registry}}
<span data-i18n="{{i18nKeyLabel}}">{{label}}</span>
<span data-i18n="{{i18nKeyLabel}}">
<span>{{label}}</span>
</span>
{{/with}}
{{> Template.dynamic template=settingsHeaderControls}}
</h3>
Expand Down
4 changes: 3 additions & 1 deletion packages/reaction-i18n/private/data/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@
"inventorySettingsLabel": "Inventory Settings",
"analyticsSettingsLabel": "Analytics Settings",
"paypalSettingsLabel": "PayPal Settings",
"genericPaymentSettingsLabel": "Generic Payment Settings"
"genericPaymentSettingsLabel": "Generic Payment Settings",
Copy link
Collaborator

@brent-hoover brent-hoover May 23, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that "Example Payment" was supposed to replace "Generic Payment" so there shouldn't be both? That must be something I missed when changing the name.

"reactionConnectLabel": "Reaction Connect",
"examplePaymentSettingsLabel": "Example Payment"
},
"userAccountDropdown": {
"profileLabel": "Profile"
Expand Down
5 changes: 2 additions & 3 deletions packages/reaction-ui/.npm/package/npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.